BorrowValue auto impl copy/clone helper from borrow #2090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
force-pushed
the
borrow-value
branch
from
286bf2c to
e7e35b7
Compare
BenLewis-Seequent
approved these changes
Aug 10, 2020
vm/src/pyobject.rs
Outdated
| fn owned_value<Owned>(&'a self) -> Owned | ||
| where | ||
| Owned: std::borrow::Borrow<<Self::Borrowed as Deref>::Target>, | ||
| <Self::Borrowed as Deref>::Target: ToOwned<Owned = Owned>, |
There was a problem hiding this comment.
I think you don't need a generic for this, can you do -> <<Self::Borrowed as Deref>::Target as ToOwned>::Owned where <Self:: Borrowed as Deref>::Target: ToOwned ?
youknowone
force-pushed
the
borrow-value
branch
from
e7e35b7 to
61be4b0
Compare
|
@Skinny121 @coolreader18 how do you think about |
|
Not sure about |
|
Although maybe I just don't like owned_value because of the name, I feel like it doesn't communicate that you're converting the value to its owned form. Maybe like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy seems ok because
*v.borrow_value()is annoying.I am considering to revert owned and clone. It doesn't give that much values