Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "go1.10" build tag from driver #1016

Merged
merged 4 commits into from Dec 12, 2019
Merged

Remove "go1.10" build tag from driver #1016

merged 4 commits into from Dec 12, 2019

Conversation

@neetle
Copy link
Contributor

@neetle neetle commented Oct 20, 2019 •
edited

Description

Some IDEs and editors seem to not acknowledge the "go1.10" build tag when
autocompleting & compiling. Removing said tag increases usibility of the
library for those stuck with these editors.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible) (N/A)
  • All tests passing
  • Extended the README / documentation, if necessary (N/A)
  • Added myself / the copyright holder to the AUTHORS file
Nathaial Murphy added 2 commits Oct 20, 2019
Nathaial Murphy
Remove "go1.10" build tag from driver.
e48b7a9 
Some IDEs and editors refuse to acknowledge the "go1.10" build tag when
autocompleting & compiling. Removing said tag increases usibility of the
library for those stuck with these editors.
Nathaial Murphy
Added self to AUTHORS file
Loading status checks…
41ef40c
@neetle neetle mentioned this pull request Oct 21, 2019
Closed
@methane
methane requested changes Oct 21, 2019
View changes
Copy link
Member

@methane methane left a comment

Please remove driver_go110.go and driver_go110_test.go, and move all code into driver.go and driver_test.go.
Nathaial Murphy
Merge driver_go110.go into driver.go (incl. tests)
Loading status checks…
63a5a6e
@methane methane mentioned this pull request Dec 11, 2019
Closed
@methane
Merge remote-tracking branch 'origin/master' into neetle-master
Loading status checks…
e3cfbab
@methane
methane approved these changes Dec 12, 2019
View changes
@methane methane merged commit b66d043 into go-sql-driver:master Dec 12, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 80.566%
Details
reireias added a commit to reireias/mysql that referenced this pull request Dec 12, 2019
@reireias
Revert "Remove "go1.10" build tag (go-sql-driver#1016)"
1edf8de 
This reverts commit b66d043.
sthagen added a commit to sthagen/mysql that referenced this pull request Dec 12, 2019
@sthagen
Merge pull request #5 from go-sql-driver/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efd3bdb 
Remove "go1.10" build tag (go-sql-driver#1016)
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@neetle @tz70s
Remove "go1.10" build tag (go-sql-driver#1016)
3670097 
Some IDEs and editors refuse to acknowledge the "go1.10" build tag when
autocompleting & compiling. Removing said tag increases usibility of the
library for those stuck with these editors.
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@neetle @tz70s
Remove "go1.10" build tag (go-sql-driver#1016)
4fdb0ae 
Some IDEs and editors refuse to acknowledge the "go1.10" build tag when
autocompleting & compiling. Removing said tag increases usibility of the
library for those stuck with these editors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@neetle @methane