Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional resultset metadata #1150

Open
wants to merge 2 commits into
base: master
from
Open

Support optional resultset metadata #1150

wants to merge 2 commits into from

Conversation

@tz70s
Copy link

@tz70s tz70s commented Aug 30, 2020 •
edited

Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue #1105

Note

I believe this flag was introduced in MySQL 8.0+ only.

Some open questions are:

  • Should we introduce this flag/system var?
  • If yes, how can we let user know the version they operate on is compatible with this flag or not? I believe we had some existing usage that may break versions, some documentation added will be great.
  • I don't really feel like current tests against MySQL matrix on CI w/ different versions are reliable, maybe a better way is catching up environment variable (e.g. DB) to test each version, instead of relying on maybeSkip.

Need your feedback on this, thank you!

Description

Add support optional resultset metadata.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@tz70s tz70s force-pushed the tz70s:support-resultset-optional-metadata branch 2 times, most recently from d9cf63e to 46e70d0 Aug 30, 2020
@tz70s tz70s changed the title WIP: Support optional resultset metadata Support optional resultset metadata Aug 30, 2020
@tz70s tz70s force-pushed the tz70s:support-resultset-optional-metadata branch 3 times, most recently from 4387f1b to 9c2dbfb Aug 30, 2020
@tz70s
Support optional resultset metadata
Loading status checks…
89bdedf 
Allow optional resultset metadata.
Can potentially improve the performance in many scenario.

Issue #1105
@tz70s tz70s force-pushed the tz70s:support-resultset-optional-metadata branch 4 times, most recently from 21f614e to 38aa54a Aug 30, 2020
@tz70s
Copy link
Author

@tz70s tz70s commented Aug 30, 2020 •
edited

Not really sure why seems this test is flaky in OSX travis

=== RUN   TestConcurrent
    driver_test.go:1859: testing up to 151 concurrent connections 
    driver_test.go:1913: reached 151 concurrent connections
    driver_test.go:1859: testing up to 151 concurrent connections 
    driver_test.go:1913: reached 150 concurrent connections
    driver_test.go:1859: testing up to 151 concurrent connections 
    driver_test.go:1910: error on conn 12: dial tcp 127.0.0.1:3306: connect: connection reset by peer
--- FAIL: TestConcurrent (1.09s)
@tz70s
Verify server response cap flags to fail earlier
Loading status checks…
b819a69
@tz70s tz70s force-pushed the tz70s:support-resultset-optional-metadata branch from 51e4ca4 to b819a69 Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@tz70s
You can’t perform that action at this time.