Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: update image versions #1103

Merged
merged 5 commits into from May 25, 2020
Merged

travis: update image versions #1103

merged 5 commits into from May 25, 2020

Conversation

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented May 17, 2020

Description

Updates the images on Travis to latest versions.
For better comparability (and thus less hacks), it further changes the mysql_wait.sh script to use the mysql client inside the docker container if docker is running.

Checklist

  • Code compiles correctly
  • All tests passing
@julienschmidt julienschmidt added this to the v1.6.0 milestone May 17, 2020
@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented May 17, 2020

Somehow the wait_mysql.sh waits forever with MySQL 8.0 on Xenial. Any idea what could be going wrong there @methane?

Job log: https://travis-ci.com/github/go-sql-driver/mysql/jobs/335790306

@julienschmidt julienschmidt force-pushed the travis-update branch from 67f314d to ee247cd May 17, 2020
@julienschmidt julienschmidt force-pushed the travis-update branch from ee247cd to 1ffb8c9 May 17, 2020
@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented May 17, 2020

Found this very helpful hint, which we never implemented: #798 (comment)
Thanks for warning us already 2 years ago @arvenil 😇

@julienschmidt julienschmidt force-pushed the travis-update branch from 9be28bf to 42f1802 May 18, 2020
@julienschmidt julienschmidt requested a review from methane May 24, 2020
@julienschmidt julienschmidt merged commit 8c3a2d9 into master May 25, 2020
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
coverage/coveralls Coverage increased (+0.06%) to 81.714%
Details
@julienschmidt julienschmidt deleted the travis-update branch May 29, 2020
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
* travis: update image versions

* travis: use mysql client inside the docker container for polling

* travis: force mysql client to connect via tcp

* travis: use root pass in mysql client

* travis: use empty root password
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
* travis: update image versions

* travis: use mysql client inside the docker container for polling

* travis: force mysql client to connect via tcp

* travis: use root pass in mysql client

* travis: use empty root password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.