Skip to content

/ adaptive

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AverageLearner: fix zero mean #276

Open
wants to merge 3 commits into
base: master
from
Open

AverageLearner: fix zero mean #276

wants to merge 3 commits into from

Conversation

@basnijholt
Copy link
Member

@basnijholt basnijholt commented May 14, 2020 •
edited

Description

Fixes #275

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
@basnijholt
split up aloss and rloss
Loading status checks…
41a50f1
@basnijholt basnijholt changed the title WIP: split up aloss and rloss WIP: AverageLearner, fix zero mean May 14, 2020
@basnijholt basnijholt changed the title WIP: AverageLearner, fix zero mean WIP: AverageLearner: fix zero mean May 14, 2020
@basnijholt
only divide by mean whenever it's not zero
Loading status checks…
e439b79
@basnijholt basnijholt changed the title WIP: AverageLearner: fix zero mean AverageLearner: fix zero mean May 14, 2020
@basnijholt
add test_zero_mean
Loading status checks…
c67ebe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AverageLearner bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

AverageLearner doesn't work with 0 mean
1 participant
@basnijholt