Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42955: Rename module_names to sys.stdlib_module_names #24332

Merged
merged 1 commit into from Jan 25, 2021
Merged

bpo-42955: Rename module_names to sys.stdlib_module_names #24332

merged 1 commit into from Jan 25, 2021

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 25, 2021 •
edited by bedevere-bot

  • Rename _Py_module_names to _Py_stdlib_module_names
  • Rename Python/module_names.h to Python/stdlib_module_names.h

https://bugs.python.org/issue42955
@vstinner
bpo-42955: Rename module_names to sys.stdlib_module_names
Loading status checks…
043dd19 
* Rename _Py_module_names to _Py_stdlib_module_names
* Rename Python/module_names.h to Python/stdlib_module_names.h
@vstinner vstinner requested a review from python/windows-team as a code owner Jan 25, 2021
@gaborbernat
gaborbernat approved these changes Jan 25, 2021
View changes
Copy link

@gaborbernat gaborbernat left a comment

@warsaw
warsaw approved these changes Jan 25, 2021
View changes
@gpshead
gpshead approved these changes Jan 25, 2021
View changes
@vstinner vstinner merged commit 9852cb3 into python:master Jan 25, 2021
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210125.23 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 42955 found
Details
bedevere/news News entry found in Misc/NEWS.d
@vstinner vstinner deleted the vstinner:stdlib_module_names branch Jan 25, 2021
@vstinner
Copy link
Member Author

@vstinner vstinner commented Jan 25, 2021

Merged, thanks for the reviews.
m000 added a commit to m000/cpython that referenced this pull request Jan 29, 2021
@vstinner @m000
bpo-42955: Rename module_names to sys.stdlib_module_names (pythonGH-2…
4492957 
…4332)

* Rename _Py_module_names to _Py_stdlib_module_names.
* Rename Python/module_names.h to Python/stdlib_module_names.h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

@warsaw warsaw

@gaborbernat gaborbernat

@python/windows-team windows-team

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@vstinner @gpshead @warsaw @gaborbernat @the-knights-who-say-ni @bedevere-bot