Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43166 Disable ceval.c optimisations for Windows debug builds #24485

Merged
merged 2 commits into from Feb 9, 2021
Merged

bpo-43166 Disable ceval.c optimisations for Windows debug builds #24485

merged 2 commits into from Feb 9, 2021
+3 −3

Conversation

@zooba
Copy link
Member

@zooba zooba commented Feb 8, 2021 •
edited by bedevere-bot

This ensures that ceval.c can be debugged.

https://bugs.python.org/issue43166
@zooba
Disable ceval.c optimisations for Windows debug builds. This ensures …
Loading status checks…
e801fbc 
…that ceval.c can be debugged.
@zooba
Copy link
Member Author

@zooba zooba commented Feb 8, 2021

FYI @gvanrossum
@gvanrossum
gvanrossum reviewed Feb 8, 2021
View changes
Include/pyport.h Outdated Show resolved Hide resolved
@zooba
Remove irrelevant options
Loading status checks…
9f4fdad
@gvanrossum
gvanrossum approved these changes Feb 9, 2021
View changes
@zooba zooba changed the title Disable ceval.c optimisations for Windows debug builds bpo-43166 Disable ceval.c optimisations for Windows debug builds Feb 9, 2021
@zooba zooba removed the skip issue label Feb 9, 2021
@zooba zooba merged commit b74396c into python:master Feb 9, 2021
10 checks passed
10 checks passed
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210209.2 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 43166 found
Details
bedevere/news "skip news" label found
@zooba zooba deleted the zooba:fixdebug branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed OS-windows skip news
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@zooba @gvanrossum @the-knights-who-say-ni @bedevere-bot