Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Move go module #468

Closed
wants to merge 5 commits into from
Closed

Move go module #468

wants to merge 5 commits into from

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Feb 9, 2021

No description provided.

@owen-mc owen-mc requested a review from a team February 9, 2021 16:56
@smowton
Copy link
Contributor

smowton commented Feb 9, 2021

Could you explain why golang/x/tools changes version and why dbscheme.stats is updated?

@owen-mc owen-mc assigned sauyon and unassigned smowton Feb 10, 2021
@sauyon
Copy link
Contributor

sauyon commented Feb 10, 2021

Few points:

So technically this is still wrong because there is now a top-level Go module in the ql test directory, which contains other modules (those tests that have stubbed dependencies). At some point I think it might be nice to have a single module for all tests which contains all the stubbed dependencies, since it would cut down on repeated stubs, but it would take some effort and Owen pointed out that any manual changes would have to be reapplied even if depstubber did what we would expect it to do and autogenerate all the stubs in child directories.

In any case, this way the actual Go code complies with what gopls wants, and we can just disable it for the ql directory.

The tools etc. have changed simply because we updated them; it's obviously optional and we can cut that out if you think it's a problem.

I suspect that the stats have changed because at some point we changed extraction and forgot to update them. The other alternative is that the Go frontend changed its output, but in any case the stats update should happen.

@sauyon
Copy link
Contributor

sauyon commented Feb 10, 2021

The tools etc. have changed simply because we updated them; it's obviously optional and we can cut that out if you think it's a problem.

It seems like one of the updates was to use an execabs package which avoids relative PATH entries, which I think may be worth having just in case. I haven't looked very carefully at what the update changes, though.

@sauyon
Copy link
Contributor

sauyon commented Aug 23, 2021

Go no longer seems to like .git directories without a go module, so closing.

@sauyon sauyon closed this Aug 23, 2021
@owen-mc owen-mc deleted the move-go-module branch August 23, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants