Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-41824: Fix indentation issue in ForwardRef docs #24495

Merged
merged 3 commits into from Feb 9, 2021
Merged

[3.8] bpo-41824: Fix indentation issue in ForwardRef docs #24495

merged 3 commits into from Feb 9, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 9, 2021 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 9, 2021
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Feb 9, 2021 •
edited

@gvanrossum I'm really sorry, I didn't notice that I didn't indent the rST directive with 3 spaces. On sphinx 3 this causes the docs to render weirdly.

Edit: The 3.9 branch isn't affected, neither is the 3.10/main one.

@gvanrossum gvanrossum merged commit 822f7c2 into python:3.8 Feb 9, 2021
4 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Feb 9, 2021

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Feb 9, 2021

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Feb 9, 2021

Sorry, @Fidget-Spinner and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 822f7c266f886677047338e8b167ba39a6abd91e 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Feb 9, 2021

Sorry @Fidget-Spinner and @gvanrossum, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 822f7c266f886677047338e8b167ba39a6abd91e 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Feb 9, 2021

Sorry, @Fidget-Spinner and @gvanrossum, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 822f7c266f886677047338e8b167ba39a6abd91e 3.7

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Feb 9, 2021

This doesn't need backporting - it only affected the 3.8 branch :). Thanks for your help Guido!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@ilevkivskyi ilevkivskyi

Assignees

@gvanrossum gvanrossum

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fidget-Spinner @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni