Skip to content

Fix link to sqlite3 enable_shared_cache documentation #24496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix link to sqlite3 enable_shared_cache documentation #24496

merged 1 commit into from
Feb 10, 2021

Conversation

orf
Copy link
Contributor

@orf orf commented Feb 9, 2021

Currently the link 404's, removing the slash fixes this.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@orf

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erlend-aasland
Copy link
Contributor

cc. @berkerpeksag @Fidget-Spinner

@orf
Copy link
Contributor Author

orf commented Feb 10, 2021

FYI I've tried to sign the CLA three times - it's really unclear what your BPO username is if you've signed in via GitHub. I've tried several variations and even changed my username in BPO to match my GitHub name to no avail.

All that is to say, do I need to sign the CLA to get this tiny doc fix in?

@erlend-aasland
Copy link
Contributor

FYI I've tried to sign the CLA three times - it's really unclear what your BPO username is if you've signed in via GitHub.

After you've logged in to BPO your username is shown in the menu to the left ("Hello, "). You can also view your BPO username as "Login Name" if you click on "Your Details".

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

FYI I've tried to sign the CLA three times - it's really unclear what your BPO username is if you've signed in via GitHub. I've tried several variations and even changed my username in BPO to match my GitHub name to no avail.

All that is to say, do I need to sign the CLA to get this tiny doc fix in?

AFAIK (and I might be completely wrong here, if so, sorry and please correct me), the CLA form checking and linking to your account is done manually by staff at the PSF. So you may have to give it some time if you just signed it yesterday. Additionally, from my hazy memory (I can't find this in the devguide right now), minor typo fixes do not necessarily need a CLA, only things that contain creative input. However, this is up to the core dev's discretion and not mine.

Edit: Ah great I found it: https://devguide.python.org/committing/?highlight=CLA#assessing-a-pull-request

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a minor fix so there is no need to wait for CLA, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants