Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43200: Fix a link to shutil.copy() in the shutil module docs #24505

Merged
merged 2 commits into from Feb 13, 2021

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 11, 2021

A link generated for the copy() function was linking to the copy
module. It should link to the shutil.copy() function instead.

Use reST markup to ensure the other functions in the sentence also
link to shutil functions.

https://bugs.python.org/issue43200

A link generated for the copy() function was linking to the copy
module.  It should link to the shutil.copy() function instead.

Use reST markup to ensure the other functions in the sentence also
link to shutil functions.
Copy link

@serverwentdown serverwentdown left a comment

LGTM

Copy link
Member

@terryjreedy terryjreedy left a comment

With only a couple of exception, this doc only uses '~shutil' when needed, for 'copy', so I removed the ones not needed. I check and there are no other instances "copy" to fix in this file.

@terryjreedy terryjreedy merged commit 762fe7d into python:master Feb 13, 2021
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210213.2 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 43200 found
Details
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 13, 2021

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 13, 2021

GH-24523 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 13, 2021

GH-24524 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
terryjreedy pushed a commit that referenced this pull request Feb 13, 2021
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants