Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43152: Update assert statement to remove unused warning #24473

Merged
merged 3 commits into from Feb 14, 2021
Merged

bpo-43152: Update assert statement to remove unused warning #24473

merged 3 commits into from Feb 14, 2021
+1 −2

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Feb 7, 2021 •
edited by bedevere-bot 

Python/ceval.c:4747:19: warning: unused variable 'code' [-Wunused-variable]
    PyCodeObject *code = (PyCodeObject *)_co;

https://bugs.python.org/issue43152
@corona10 corona10 requested a review from markshannon as a code owner Feb 7, 2021
@corona10 corona10 changed the title no-issue Update assert statement to remove unused warning bpo-43152 Update assert statement to remove unused warning Feb 7, 2021
@corona10 corona10 changed the title bpo-43152 Update assert statement to remove unused warning bpo-43152: Update assert statement to remove unused warning Feb 7, 2021
@corona10 corona10 removed the skip news label Feb 7, 2021
@corona10
bpo-43152: Update assert statement to remove unused warning
Loading status checks…
7a45047
@corona10 corona10 force-pushed the corona10:unused_ceval branch from bdf630e to 7a45047 Feb 7, 2021
@corona10 corona10 added skip news and removed skip issue labels Feb 7, 2021
@corona10 corona10 requested a review from vstinner Feb 9, 2021
@vstinner
vstinner reviewed Feb 9, 2021
View changes
Python/ceval.c Outdated Show resolved Hide resolved
@corona10 @vstinner
Update Python/ceval.c
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27f2172 
Co-authored-by: Victor Stinner <vstinner@python.org>
@corona10 corona10 requested a review from vstinner Feb 10, 2021
@vstinner
vstinner approved these changes Feb 11, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.
@iritkatriel
iritkatriel reviewed Feb 11, 2021
View changes
Python/ceval.c Outdated Show resolved Hide resolved
@corona10
bpo-43152 Reflect code review
Loading status checks…
8e5ee98
@corona10 corona10 merged commit 3cf0833 into python:master Feb 14, 2021
10 checks passed
10 checks passed
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210214.2 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 43152 found
Details
bedevere/news "skip news" label found
sthagen added a commit to sthagen/cpython that referenced this pull request Feb 14, 2021
@sthagen
Merge pull request #386 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a771615 
bpo-43152: Update assert statement to remove unused warning (pythonGH-24473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@vstinner vstinner

@markshannon markshannon

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@corona10 @vstinner @iritkatriel @the-knights-who-say-ni @bedevere-bot