fix(@schematics/angular): avoid unuse imports for canLoad guard generation #19920
+62
−20
Conversation
This comment has been hidden.
This comment has been hidden.
|
@googlebot I signed it! |
|
Thanks for your contribution. I think it's cleaner if you update https://github.com/angular/angular-cli/blob/0f61827dcf605b193d7d1a83d325e230cc973596/packages/schematics/angular/guard/index.ts#L43:L46 Also, can you kindly add a unit test here https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/guard/index_spec.ts? Thanks. |
|
@alan-agius4 sure. is there a way to deal with this bazel error under Windows? I ran into an issue by running unit tests: then Is there a way to fix the download ? |
|
@billyjov, have you installed Visual C++ Redistributable for Visual Studio 2015 which is a prerequisite? See: https://docs.bazel.build/versions/master/install-windows.html |
billyjov
force-pushed the
billyjov:feature/fix-guard-imports
branch
from
e5e1f93
to
85a2109
billyjov
force-pushed the
billyjov:feature/fix-guard-imports
branch
from
85a2109
to
c63be7b
...ages/schematics/angular/guard/files/__name@dasherize__.guard.ts.template
Outdated
Show resolved
Hide resolved
billyjov
force-pushed the
billyjov:feature/fix-guard-imports
branch
from
b6ed523
to
e004847
alan-agius4
force-pushed the
billyjov:feature/fix-guard-imports
branch
from
e004847
to
cad8944
|
LGTM, thanks for your contribution. |
alan-agius4
force-pushed the
billyjov:feature/fix-guard-imports
branch
from
cad8944
to
f2c4e4d
alan-agius4
merged commit 3081524
into
angular:master
12 checks passed
12 checks passed
ci/angular: merge status
All checks passed!
ci/angular: size
No size change against base branch.
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.