Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Fixed typos in documentation #19511

Merged
merged 4 commits into from Feb 20, 2021
Merged

DOC Fixed typos in documentation #19511

merged 4 commits into from Feb 20, 2021
+4 −4

Conversation

@Ashish013
Copy link
Contributor

@Ashish013 Ashish013 commented Feb 20, 2021

This pull request fixes a typo in the documentation of sklearn.model_selection.GridSearchCV.
@Ashish013
Fixed a typo in the documentation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b47b264
@thomasjpfan
thomasjpfan reviewed Feb 20, 2021
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Thank you for the PR @Ashish013 !

May you fix the same typo in the following places as well?

sklearn/inspection/_permutation_importance.py:118:        If `scoring` reprents multiple scores, one can use:
sklearn/model_selection/_search.py:1349:        If `scoring` reprents multiple scores, one can use:
sklearn/model_selection/_validation.py:77:        If `scoring` reprents multiple scores, one can use:
Ashish013 added 3 commits Feb 20, 2021
@Ashish013
Fixed a typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d397471
@Ashish013
Fixed another typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aff995e
@Ashish013
Fixed a typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3b338c2
@Ashish013 Ashish013 changed the title Fixed a typo in GridSearchCV Fixed typos in documentation Feb 20, 2021
@thomasjpfan
thomasjpfan approved these changes Feb 20, 2021
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

LGTM
@thomasjpfan thomasjpfan changed the title Fixed typos in documentation DOC Fixed typos in documentation Feb 20, 2021
@thomasjpfan thomasjpfan merged commit 70c6ac9 into scikit-learn:main Feb 20, 2021
27 checks passed
27 checks passed
triage
Details
labeler
Details
labeler
Details
Check build trigger
Details
Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}-${{ matrix.manylinux_image }}
Details
Source distribution
Details
Upload to Anaconda
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
scikit-learn.scikit-learn Build #20210220.17 succeeded
Details
scikit-learn.scikit-learn (Get Git Commit) Get Git Commit succeeded
Details
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
scikit-learn.scikit-learn (Linux py36_conda_openblas) Linux py36_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py36_ubuntu_atlas) Linux py36_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit) Linux32 py36_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit) Windows py36_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl) macOS pylatest_conda_forge_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp) macOS pylatest_conda_mkl_no_openmp succeeded
Details
@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Feb 20, 2021

Thank you for the contribution @Ashish013 !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan

Assignees
No one assigned
Labels
Documentation module:model_selection
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Ashish013 @thomasjpfan