Skip to content

DOC update copyright year forever #19463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

glemaitre
Copy link
Member

Instead of updating every year, let's use Python.

Copy link
Member

@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not :)

@rth rth merged commit 8c05919 into scikit-learn:main Feb 15, 2021
@GaelVaroquaux
Copy link
Member

Legally, that does not work: the year assigned here is the year that the setup.py is executed, and not the last year that the code was written.

@rth
Copy link
Member

rth commented Feb 15, 2021

Right, but the alternative seems to be to update that manually each year, and forget to do it on time half the time.

If we are talking about scikit-learn.org that doc/conf.py is going to be run on each commit on master, which does correspond the the last date when code is changed. Of course anyone else could build the doc, and possibly make unrelated changes to the copyright year, but do we really need to worry about that, we don't really have control over it?

@rth
Copy link
Member

rth commented Feb 15, 2021

I'm not convinced that year range has any weight in any case legally speaking. Say you forget to update the end year, that does not change in any way how to the LICENSE or copyright applies to the software, as far as I can tell. Unless we are talking about copyright expiration date, if it applies.

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Feb 15, 2021 via email

@rth
Copy link
Member

rth commented Feb 15, 2021

OK, then doesn't copyright expiration takes place in 70+ years from the creation date https://www.copyright.gov/help/faq/faq-duration.html ? Following that logic we don't need to update those years on a 10 year time scale...

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Feb 15, 2021 via email

@rth
Copy link
Member

rth commented Feb 15, 2021

OK, let's revert then.

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants