Skip to content

/ vuepress

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 page does not support i18n #1987

Open
ludanxer opened this issue Oct 27, 2019 · 4 comments
Open

404 page does not support i18n #1987

ludanxer opened this issue Oct 27, 2019 · 4 comments
Labels
complexity: easy contribution welcome effort: medium good first issue topic: theme type: feature request

Comments

@ludanxer
Copy link
Contributor

@ludanxer ludanxer commented Oct 27, 2019

  • I confirm that this is an issue rather than a question.

Bug report

I just find this on stackoverflow, and test it on the official website

Steps to reproduce

Try to visit vuepress.vuejs.org/zh/test

What is expected?

A 404 page with Chinese and

<html lang="zh-CN" >

What is actually happening?

<html lang="en-US" >

Other relevant information

  • Output of npx vuepress info in my VuePress project:
@dzetah
Copy link

@dzetah dzetah commented Nov 6, 2019

Hello @ludanxer, this seems like a good fist issue for me on this project !
I will submit a PR for it later this week ;)
dzetah added a commit to dzetah/vuepress that referenced this issue Nov 6, 2019
@dzetah
chore(feat): localize 404 page (fix vuejs#1987)
c691d8e
@ThaddeusJiang
Copy link

@ThaddeusJiang ThaddeusJiang commented Apr 1, 2020

Hi @dzetah
Did you submit a PR?
@ludanxer
Copy link
Contributor Author

@ludanxer ludanxer commented Apr 1, 2020

Yes, he kindly did #2004 , I believe it's not ready because

Currently, it will show the default messages first, and change to the locale messages.

It's not so perfect 🤔

https://deploy-preview-2004--vuepress.netlify.com/zh/guide/aaa

demo-locale
@dzetah
Copy link

@dzetah dzetah commented Apr 1, 2020

Hi @dzetah

Did you submit a PR?

Yes I did but I have to fix it because there’s a still a small bug. I had no time at all to do that recently, I’ll try to do it this week.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity: easy contribution welcome effort: medium good first issue topic: theme type: feature request
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@kefranabg @dzetah @ThaddeusJiang @ludanxer
You can’t perform that action at this time.