Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use conda-forge compilers #38219

Merged
merged 1 commit into from Dec 2, 2020

Conversation

@xhochy
Copy link
Contributor

@xhochy xhochy commented Dec 1, 2020

Additionally I switched to the miniforge3 image as this bases its installation on conda-forge
and I also have used mamba to install the environment as this massively saves time.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
Additionally I switched to the miniforge3 image as this bases its installation on conda-forge
and I also have used `mamba` to install the environment as this massively saves time.
@xhochy
Copy link
Contributor Author

@xhochy xhochy commented Dec 1, 2020

I'm not really sure where this is used / why this is useful but as it seems that it is broken and people seem to use it somehow, I gave it some love.

@jreback jreback added the Build label Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback
Copy link
Contributor

@jreback jreback commented Dec 2, 2020

yeah this is fine. I don't think we are actively using this, assume you have tested it?

@xhochy
Copy link
Contributor Author

@xhochy xhochy commented Dec 2, 2020

yeah this is fine. I don't think we are actively using this, assume you have tested it?

Yes, tested and works.

@jreback jreback merged commit a48957b into pandas-dev:master Dec 2, 2020
19 checks passed
19 checks passed
Checks
Details
pre-commit
Details
Web and docs
Details
codecov/patch Coverage not affected when comparing 2a115d5...2d6e8b7
Details
codecov/project 90.64% (target 82.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20201201.63 succeeded
Details
pandas-dev.pandas (Linux py37) Linux py37 succeeded
Details
pandas-dev.pandas (Linux py37_locale_slow) Linux py37_locale_slow succeeded
Details
pandas-dev.pandas (Linux py37_minimum_versions) Linux py37_minimum_versions succeeded
Details
pandas-dev.pandas (Linux py37_slow) Linux py37_slow succeeded
Details
pandas-dev.pandas (Linux py38) Linux py38 succeeded
Details
pandas-dev.pandas (Linux py38_locale) Linux py38_locale succeeded
Details
pandas-dev.pandas (Linux py38_np_dev) Linux py38_np_dev succeeded
Details
pandas-dev.pandas (Linux py39) Linux py39 succeeded
Details
pandas-dev.pandas (Windows py37_np16) Windows py37_np16 succeeded
Details
pandas-dev.pandas (Windows py38_np18) Windows py38_np18 succeeded
Details
pandas-dev.pandas (macOS py37_macos) macOS py37_macos succeeded
Details
pandas-dev.pandas (py37_32bit) py37_32bit succeeded
Details
@jreback
Copy link
Contributor

@jreback jreback commented Dec 2, 2020

thanks @xhochy

@xhochy xhochy deleted the xhochy:fix-compilers-in-dockerimage branch Dec 2, 2020
@yehoshuadimarsky
Copy link
Contributor

@yehoshuadimarsky yehoshuadimarsky commented Jan 24, 2021

just saw this, FWIW I use this, to get an isolated environment for working on pandas. Especially if I'm on Windows and want to use the Linux shell, thanks @xhochy for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants