Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: fix template substitution in pad/bfill docstrings #39978

Merged
merged 4 commits into from Feb 24, 2021
Merged

DOC: fix template substitution in pad/bfill docstrings #39978

merged 4 commits into from Feb 24, 2021

Conversation

dylanp-git
Copy link
Contributor

@dylanp-git dylanp-git commented Feb 22, 2021 •
edited by simonjayhawkins

  • closes #39640
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

#39640 Added doc tag above ffill() to substitute klass

@jreback jreback added this to the 1.2.3 milestone Feb 22, 2021
@jreback jreback added the Docs label Feb 22, 2021
@jreback
Copy link
Contributor

@jreback jreback commented Feb 22, 2021

cc @simonjayhawkins @jorisvandenbossche

lgtm.

@jreback jreback changed the title Fix series pad DOC: update series pad Feb 22, 2021
@simonjayhawkins simonjayhawkins linked an issue that may be closed by this pull request Feb 23, 2021
DOC: Series.pad has template variables that are not replaced #39640
Closed
simonjayhawkins
simonjayhawkins requested changes Feb 23, 2021
View changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

can we also fix bfill/backfill while doing this. basically same issue, needs same change applied to L6516

@dylanp-git
Copy link
Contributor Author

@dylanp-git dylanp-git commented Feb 23, 2021

yeah I can do that. I'm not sure what "Igtm" or "L6516" mean/referring to, if I need to know then could someone let me know please.

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 23, 2021

@dylanp-git lgtm means 'looks good to me'; L6516 is line number 6516

@dylanp-git
Copy link
Contributor Author

@dylanp-git dylanp-git commented Feb 23, 2021

@dylanp-git lgtm means 'looks good to me'; L6516 is line number 6516

aha thankyou, I'm slowly learning the lingo!!

@jorisvandenbossche jorisvandenbossche changed the title DOC: update series pad DOC: fix template substitution in pad/bfill docstrings Feb 24, 2021
@jorisvandenbossche jorisvandenbossche merged commit dec7d21 into pandas-dev:master Feb 24, 2021
20 of 22 checks passed
@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Feb 24, 2021

Thanks a lot @dylanp-git !

@meeseeksmachine meeseeksmachine mentioned this pull request Feb 24, 2021
Merged
meeseeksmachine added a commit to meeseeksmachine/pandas that referenced this issue Feb 24, 2021
@dylanp-git @meeseeksmachine
Backport PR pandas-dev#39978: DOC: fix template substitution in pad/b…
b0b4710 
…fill docstrings
@dylanp-git
Copy link
Contributor Author

@dylanp-git dylanp-git commented Feb 24, 2021

Thanks a lot @dylanp-git !

No worries! I was going to look into it again later as only 20/22 checks passed?

On another note, how many "good first issue" issues do you think I should do before trying something a bit more in-depth?

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 24, 2021

only 20/22 checks passed?

the failures were unrelated (sometimes that happens)

how many "good first issue" issues do you think I should do before trying something a bit more in-depth?

IMO if you've got familiar with the contribution workflow then you could start immediately

jreback pushed a commit that referenced this issue Feb 24, 2021
@dylanp-git @meeseeksmachine
Backport PR #39978: DOC: fix template substitution in pad/bfill docst…
e0321f1 
…rings (#40017)

Co-authored-by: Dylan Percy <dylanpercy@googlemail.com>
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins

@jorisvandenbossche jorisvandenbossche

Assignees
No one assigned
Labels
Docs Missing-data
Projects
None yet
Milestone
1.2.3
Linked issues

Successfully merging this pull request may close these issues.

DOC: Series.pad has template variables that are not replaced
5 participants
@dylanp-git @jreback @MarcoGorelli @jorisvandenbossche @simonjayhawkins