-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-42808: Add PyType_Type.tp_vectorcall for type(obj) performance #24058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Objects/typeobject.c
Outdated
if (!_PyArg_NoKwnames("type", kwnames)) { | ||
return NULL; | ||
} | ||
PyObject *tp = (PyObject *)Py_TYPE(args[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can use Py_NewRef()
in this case?
This PR is stale because it has been open for 30 days with no activity. |
@markshannon As code owner, do you think there is any worth to this? |
Yes, I do. |
LGTM. Let's rerun the tests before merging as they are a month old. |
Any update on this? I'm seeing some nice benchmarks:
|
@markshannon Any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I will merge this PR after tests are passed ;)
cc @markshannon
|
Buildbot failure is unrelated to this PR |
https://bugs.python.org/issue42808