[PhpUnitBridge] Fix qualification of deprecations triggered by the debug class loader #38597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
reviewed
Oct 19, 2020
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
reviewed
Oct 19, 2020
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
phpunit-bridge-patch-1
branch
3 times, most recently
from
2976c0e
to
7b889fb
Compare
nicolas-grekas
reviewed
Nov 20, 2020
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/debug_class_loader_autoload.phpt
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/debug_class_loader_autoload.phpt
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
phpunit-bridge-patch-1
branch
from
7b889fb
to
b40f4ff
Compare
|
Tests are green |
fancyweb
force-pushed
the
phpunit-bridge-patch-1
branch
from
b40f4ff
to
dff5394
Compare
nicolas-grekas
approved these changes
Nov 26, 2020
|
Thank you @fancyweb. |
This was referenced Nov 29, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I tested it successfully against the two examples stof gave in the issue. However, I don't see how to write a working real test for this.
The solution I found is to add the missing checked file in the original files stack so when the type of the deprecation is computed instead of having "self" -> "self", we have "vendor" -> "self".