Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Require doctrine/persistence 2 #39118
Conversation
|
As there is no change in the composer.json of the doctrine bridge, you have no guarantee that doctrine/persistence 2 is actually used when using the subtree packages. |
greg0ire
force-pushed the
greg0ire:cleanup-autoload-calls
branch
from
e3d866e
to
418da2b
|
Making Persistence 2.0 a requirement would basically render our codebase incompatible with ORM 2.6, correct? |
|
ORM 2.6 is EOL AFAICT |
|
I think it would, but I don't think it's a big deal, for reasons pointed out by @stof |
|
Yeah, I think we're good. It's just that the Bridge's composer.json says |
|
@alcaeus is the ODM 1.3.x still maintained (and supported by a version of the bundle compatible with Symfony 5) ? Because that would also drop support for the ODM 1.3.x |
We could update that one to |
|
Should I bump the ORM constraint globally as well? |
|
@greg0ire Yes, please. The ORM version referenced there can be considered antique by now. |
greg0ire
force-pushed the
greg0ire:cleanup-autoload-calls
branch
from
418da2b
to
1fcf6fa
It's no longer supported, so we can start the process of dropping support for it. |
|
What about doing it in the 5.2 branch instead? |
This allows us to remove autoload calls that are necessary for the persistence 1 backwards-compatibility layer to work. The require-dev constraints on doctrine/orm are bumped to ^2.7.3 because lower versions are not compatible with doctrine/persistence 2.
greg0ire
force-pushed the
greg0ire:cleanup-autoload-calls
branch
from
1fcf6fa
to
574a184
|
@fabpot you're right, done! |
This allows us to remove autoload calls that are necessary for the
persistence 1 backwards-compatibility layer to work.
This is a follow up of #35728