[Serializer] Fix denormalizing scalar with UnwrappingDenormalizer #39180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilledejoye
force-pushed
the
bugfix-38983/scalar-denormalization-unwrapping
branch
from
8679530
to
21ce093
Compare
derrabus
reviewed
Nov 26, 2020
camilledejoye
force-pushed
the
bugfix-38983/scalar-denormalization-unwrapping
branch
from
21ce093
to
98cf389
Compare
derrabus
approved these changes
Nov 26, 2020
fabpot
approved these changes
Nov 27, 2020
|
Thank you @camilledejoye. |
hultberg
pushed a commit
to hultberg/symfony
that referenced
this issue
Sep 17, 2021
…ngDenormalizer (camilledejoye) This PR was merged into the 5.1 branch. Discussion ---------- [Serializer] Fix denormalizing scalar with UnwrappingDenormalizer | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#38983 | License | MIT | Doc PR | none In order to work the `UnwrappingDenormlizer` needs to be called first to unwrap the data so that it can be handled by other denormalizers. To not introduce any BC break this PR does not move the logic into it's own class, instead it checks if a denormalizer supports the data and only denormalize scalar values if there is none. Commits ------- 98cf389 fix denormalizing scalar with UnwrappingDenormalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In order to work the
UnwrappingDenormlizerneeds to be called first to unwrap the data so that it can be handled by other denormalizers.To not introduce any BC break this PR does not move the logic into it's own class, instead it checks if a denormalizer supports the data and only denormalize scalar values if there is none.