[Notifier] [Discord] Use private const and mb_strlen() #39492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check how Discord behaves as I wondered in my comment ? |
nicolas-grekas
reviewed
Dec 17, 2020
| @@ -29,6 +29,8 @@ final class DiscordTransport extends AbstractTransport | |||
| { | |||
| protected const HOST = 'discord.com'; | |||
|
|
|||
| private const MAX_SUBJECT_LENGTH = 2000; | |||
There was a problem hiding this comment.
it's called TEXT_LIMIT in the Slack bridge 5.2
maybe SUBJECT_LIMIT here? or another name in the Slack bridge?
| @@ -65,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
|
|
|||
| $content = $message->getSubject(); | |||
|
|
|||
| if (\strlen($content) > 2000) { | |||
| if (mb_strlen($content) > self::MAX_SUBJECT_LENGTH) { | |||
There was a problem hiding this comment.
calling mb_* without an explicit charset is something that should be banned in all situations.
It's a bit like gambling with charsets :)
UTF-8 must be specified here (and only utf8 is supported, since we use json along the path to Discord)
|
It seems ok. Should I run some tests with discord api? |
OskarStark
reviewed
Dec 17, 2020
src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Dec 17, 2020
src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Dec 17, 2020
|
Thank you @OskarStark. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
like proposed by @nicolas-grekas in https://github.com/symfony/symfony/pull/39444/files#r542288432