[DoctrineBridge] Fix circular loop with EntityManager #39799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
This was referenced Jan 12, 2021
jderusse
force-pushed
the
fix-em-loop
branch
2 times, most recently
from
93881ab
to
5f8f645
Compare
nicolas-grekas
reviewed
Jan 12, 2021
src/Symfony/Bridge/Doctrine/Tests/ContainerAwareEventManagerTest.php
Outdated
Show resolved
Hide resolved
jderusse
force-pushed
the
fix-em-loop
branch
3 times, most recently
from
f2ac22f
to
7d1cfac
Compare
nicolas-grekas
requested changes
Jan 14, 2021
jderusse
force-pushed
the
fix-em-loop
branch
2 times, most recently
from
fefa4d1
to
b488770
Compare
chalasr
approved these changes
Jan 14, 2021
nicolas-grekas
approved these changes
Jan 14, 2021
|
Thank you @jderusse. |
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR fix a segfault in EntityManager by making the LazyEventManager handle EventSubscriber in a lazy way.
Maybe #34200 too