Fix problem when SYMFONY_PHPUNIT_VERSION is empty string value #39858
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I did a quick review of this PR, I think most things looks good. I think @ro0NL has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus
approved these changes
Jan 17, 2021
|
The change requests by the fabbot are not related to the changes in this PR and not possible for the simple-phpunit script as I think we support here a lower php version. |
nicolas-grekas
reviewed
Jan 18, 2021
nicolas-grekas
approved these changes
Jan 18, 2021
xabbuh
approved these changes
Jan 18, 2021
fabpot
approved these changes
Jan 18, 2021
|
Thank you @alexander-schranz. |
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This should fix that when
SYMFONY_PHPUNIT_VERSIONis set again on empty:it does not error with: