Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uid] Unable to extend Uuid/Ulid and use fromString() #39900

Merged
merged 0 commits into from Jan 20, 2021
Merged

[Uid] Unable to extend Uuid/Ulid and use fromString() #39900

merged 0 commits into from Jan 20, 2021

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jan 20, 2021 •
edited

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR -

Before:

CustomUuid::fromString(...) // returns `Uuid`

After:

CustomUuid::fromString(...) // returns `CustomUuid`

same for Ulid class.

cc @fancyweb

@OskarStark OskarStark changed the base branch from 5.x to 5.1 Jan 20, 2021
@OskarStark
Copy link
Contributor Author

@OskarStark OskarStark commented Jan 20, 2021

Travis failure unrelated

@OskarStark OskarStark requested a review from nicolas-grekas Jan 20, 2021
fancyweb
fancyweb requested changes Jan 20, 2021
View changes
src/Symfony/Component/Uid/Tests/Fixture/CustomUlid.php Outdated Show resolved Hide resolved
src/Symfony/Component/Uid/Tests/Fixture/CustomUlid.php Outdated Show resolved Hide resolved
src/Symfony/Component/Uid/Uuid.php Outdated Show resolved Hide resolved
src/Symfony/Component/Uid/Ulid.php Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Jan 20, 2021
@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 20, 2021

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 64c8a55 into symfony:5.1 Jan 20, 2021
@OskarStark OskarStark deleted the bug/return-static branch Jan 20, 2021
This was referenced Jan 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas

@fancyweb fancyweb

Assignees
No one assigned
Labels
Bug Status: Reviewed Uid
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OskarStark @nicolas-grekas @fancyweb @carsonbot