[PhpUnitBridge] Allow relative path to composer cache #39909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not as a bugfix? It looks like one to me. |
jderusse
force-pushed
the
phpunit-composer-cache
branch
from
2168475
to
6e464c6
Compare
jderusse
force-pushed
the
phpunit-composer-cache
branch
from
6e464c6
to
aea8b98
Compare
carsonbot
changed the title
nicolas-grekas
reviewed
Jan 20, 2021
nicolas-grekas
reviewed
Jan 20, 2021
jderusse
force-pushed
the
phpunit-composer-cache
branch
from
aea8b98
to
cde0ffd
Compare
nicolas-grekas
approved these changes
Jan 23, 2021
|
Thank you @jderusse. |
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When users defines a relative path in the
COMPOSER_CACHE_DIRenv variable,The
simple-phpunitcode, by changing the directory (withchdir), give to composer a different context. At the end, composer stores its cache inside thevendor/bin/.phpunitfolder, and inside thevendor/bin/.phpunit/phpunit-X.Y.Zfolder.This PR convert the relative path provided by the user into Absolute path.