fix validator when we have false returned by the current element of the iterator #40060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FabienSalles
commented
Feb 1, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #40057 |
| License | MIT |
FabienSalles
force-pushed
the
fix_validator_with_empty_iterator
branch
from
97521b8
to
012130f
Compare
|
@xabbuh my tests failed because of deprecation notices with my anonymous classes. Why is it not possible ? Thanks in advance :). |
|
something looks weird in these deprecations. they look truncated. |
nicolas-grekas
reviewed
Feb 2, 2021
here is how to fix the failure (which is quite cryptic right now, I'm going to submit a fix in a separate PR)
src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
Outdated
Show resolved
Hide resolved
fix coding styles add type in return
FabienSalles
force-pushed
the
fix_validator_with_empty_iterator
branch
from
012130f
to
a9e9359
Compare
stof
approved these changes
Feb 2, 2021
xabbuh
approved these changes
Feb 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.