Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42129: Add support for resources in namespaces #24670

Merged
merged 7 commits into from Mar 4, 2021

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Feb 28, 2021

And sync with importlib_resources 5.0.3.

https://bugs.python.org/issue42129

@jaraco jaraco force-pushed the feature/42129-resources-namespace-packages branch from ca3c385 to ecb7df1 Feb 28, 2021
@jaraco
Copy link
Member Author

@jaraco jaraco commented Feb 28, 2021

Annoyingly, this change includes adoption of black in the backport, so includes all of the flux and losses in readability that brings.

@jaraco
Copy link
Member Author

@jaraco jaraco commented Mar 4, 2021

According to the test failures, something is modifying sys.path.

@jaraco jaraco force-pushed the feature/42129-resources-namespace-packages branch from 84008ab to a7555f6 Mar 4, 2021
@jaraco jaraco merged commit 6714825 into master Mar 4, 2021
11 checks passed
@jaraco jaraco deleted the feature/42129-resources-namespace-packages branch Mar 4, 2021
gvanrossum added a commit to gvanrossum/cpython that referenced this issue Mar 10, 2021
* Unify behavior in ResourceReaderDefaultsTests and align with the behavior found in importlib_resources.
* Equip NamespaceLoader with a NamespaceReader.
* Apply changes from importlib_resources 5.0.4
@kousu
Copy link

@kousu kousu commented Apr 7, 2021

Thank you so much for this!

I spent a long time this weekend trying to work around this for https://github.com/sct-data/spinalcordtoobox-data-template until I eventually just gave up.

kreathon added a commit to kreathon/cpython that referenced this issue May 2, 2021
* Unify behavior in ResourceReaderDefaultsTests and align with the behavior found in importlib_resources.
* Equip NamespaceLoader with a NamespaceReader.
* Apply changes from importlib_resources 5.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants