New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: overflow in astype(td64ns) #40008

Merged

jreback merged 5 commits into pandas-dev:master from jbrockmendel:ref-fillna

Feb 24, 2021

Member

jbrockmendel commented Feb 23, 2021

closes #xxxx
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry

jbrockmendel added 5 commits


          BUG: overflow in astype(td64ns)

082069e


          whatsnew

5ae928f


          lint fixup

8e59554


          update test usage

e303df3


          np version compat

c590124

jreback added the Timedelta label

jreback added this to the 1.3 milestone

jreback added the Bug label

jreback merged commit b761848 into pandas-dev:master

17 of 22 checks passed

Contributor

jreback commented Feb 24, 2021

seem to remember a bug report about this, but could be imagintion

jbrockmendel deleted the ref-fillna branch

spencerkclark mentioned this pull request

BUG: OutOfBoundsTimedelta not raised for out-of-bounds Timedelta #36615

Closed

3 tasks

Member

simonjayhawkins commented Jul 1, 2021

This results in a 5.22x slowdown in one of our benchmarks

https://simonjayhawkins.github.io/fantastic-dollop/#inference.ToTimedelta.time_convert_int?branch=1.2.x&branch=1.3.x&commits=b7618487

Member Author

jbrockmendel commented Jul 1, 2021

This results in a 5.22x slowdown in one of our benchmarks

Yah AFAICT this is unavoidable if we want to fix the bug. numpy/numpy#16352 is about fixing the astype upstream.

Member Author

jbrockmendel commented Jul 1, 2021

BTW looking at the regressions listed, I think we can hit "ignore" for the TimestampProperties.time_freqstr ones, since those are driven by a deprecation of freqstr (and are still measured in ns)

simonjayhawkins mentioned this pull request

DEPR: Timestamp.freq #41586

Merged

4 tasks

Member

simonjayhawkins commented Jul 1, 2021

lts in a 5.22x slowdown in one of our benchmarks

Yah AFAICT this is unavoidable if we want to fix the bug. numpy/numpy#16352 is about fixing the astype upstream.

ok. have ignored https://simonjayhawkins.github.io/fantastic-dollop/#regressions?sort=3&dir=desc&branch=1.3.x

jbrockmendel mentioned this pull request

RLS: 1.3.1 #42343

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment