Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE update pre-commit-config #40125

Merged
merged 1 commit into from Mar 1, 2021
Merged

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 28, 2021

  • Ensure all linting tests pass, see here for how to run them

Am doing this manually (instead of the automated job tomorrow) in order to fixup some minor things

@MarcoGorelli MarcoGorelli added the Style label Feb 28, 2021
@MarcoGorelli MarcoGorelli requested a review from jreback Feb 28, 2021
@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 28, 2021

LGTM; npdev failures look unrelated

@jreback jreback added this to the 1.3 milestone Mar 1, 2021
@jreback jreback merged commit ec6abbf into pandas-dev:master Mar 1, 2021
20 of 22 checks passed
20 of 22 checks passed
Checks
Details
Linux_py37_locale
Details
pre-commit
Details
Web and docs
Details
Linux_py37_cov
Details
Test experimental data manager
Details
pandas-dev.pandas Build #20210228.22 had test failures
Details
pandas-dev.pandas (Linux py38_np_dev) Linux py38_np_dev failed
Details
codecov/patch Coverage not affected when comparing f4b67b5...1a15b70
Details
codecov/project 90.56% (target 82.00%)
Details
pandas-dev.pandas (Linux py37) Linux py37 succeeded
Details
pandas-dev.pandas (Linux py37_locale_slow) Linux py37_locale_slow succeeded
Details
pandas-dev.pandas (Linux py37_minimum_versions) Linux py37_minimum_versions succeeded
Details
pandas-dev.pandas (Linux py37_slow) Linux py37_slow succeeded
Details
pandas-dev.pandas (Linux py38) Linux py38 succeeded
Details
pandas-dev.pandas (Linux py38_locale) Linux py38_locale succeeded
Details
pandas-dev.pandas (Linux py38_slow) Linux py38_slow succeeded
Details
pandas-dev.pandas (Linux py39) Linux py39 succeeded
Details
pandas-dev.pandas (Windows py37_np16) Windows py37_np16 succeeded
Details
pandas-dev.pandas (Windows py38_np18) Windows py38_np18 succeeded
Details
pandas-dev.pandas (macOS py37_macos) macOS py37_macos succeeded
Details
pandas-dev.pandas (py37_32bit) py37_32bit succeeded
Details
@jreback
Copy link
Contributor

@jreback jreback commented Mar 1, 2021

thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the MarcoGorelli:update-pygrep branch Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants