BUG: more specific .drop() message when keys not found #40177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "not found in axis" to "not found in columns"
phofl
reviewed
Mar 2, 2021
| @@ -5866,7 +5866,7 @@ def drop(self: _IndexT, labels, errors: str_t = "raise") -> _IndexT: | |||
| mask = indexer == -1 | |||
| if mask.any(): | |||
| if errors != "ignore": | |||
| raise KeyError(f"{labels[mask]} not found in axis") | |||
| raise KeyError(f"{labels[mask]} not found in columns") | |||
There was a problem hiding this comment.
You can not do it this way. We are running through here too, if the user drops something from the index. This would be very misleading. Also you have to adjust tests
There was a problem hiding this comment.
Sure, so what do you think will be the right way to do ?
There was a problem hiding this comment.
@phofl Does Index have an attribute that determines whether it is a column or index axis? If it does, it could use that the change the error message. If not, an alternative is to catch this error in DataFrame.drop and rethrow with a more specific message.
jreback
changed the title
jreback
added
Error Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "not found in axis" to "not found in columns"