Skip to content

/ cube.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cubejs-client-core): table pivot #672

Merged
merged 10 commits into from Jun 17, 2020
Merged

fix(cubejs-client-core): table pivot #672

merged 10 commits into from Jun 17, 2020

Conversation

@vasilev-alex
Copy link
Member

@vasilev-alex vasilev-alex commented May 26, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Table pivot fix, table columns upgrade
@vasilev-alex
fix(cubejs-client-core): table pivot
Loading status checks…
1063a70
@vasilev-alex
tablePivot tests
60de594
@vasilev-alex
test: fix
Loading status checks…
f5aa987
@vasilev-alex
fix: tablePivot, tests
Loading status checks…
35c4b9c
@vasilev-alex
Merge remote-tracking branch 'origin/master' into table-pivot
4d1e095
@vasilev-alex
fix: tableColumns, tests
Loading status checks…
23ebc85
@vasilev-alex
fix: fromEntries replacement
Loading status checks…
8065878
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 15, 2020 •
edited

Codecov Report

Merging #672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          40       40           
  Lines        3319     3319           
=======================================
  Hits         2679     2679           
  Misses        640      640

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb3da9...1869723. Read the comment docs.
@vasilev-alex vasilev-alex marked this pull request as ready for review Jun 15, 2020
@vasilev-alex
docs: tablePivot, tableColumns
Loading status checks…
b3577b4
@vasilev-alex
feat(docs-gen): typeDefs support
Loading status checks…
1869723
@vasilev-alex
Merge branch 'master' into table-pivot
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7195540
@paveltiunov paveltiunov merged commit 70015f5 into master Jun 17, 2020
7 checks passed
7 checks passed
License Compliance All checks passed.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: react_dashboard_guide Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
guides Workflow: guides
Details
lint Workflow: lint
Details
test Workflow: test
Details
@hassankhan hassankhan deleted the table-pivot branch Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@vasilev-alex @codecov-commenter @paveltiunov