improve GitHub Actions workflows #1190
Merged
+117
−129
Conversation
- add windows to build matrix - use newer versions of MySQL and MariaDB
.github/workflows/test.yml
Outdated
| pull_request: | ||
| push: | ||
| branches: | ||
| - "master" |
methane
Jan 31, 2021
Member
Why restrict the branch?
When I pushed a new branch to my fork and I want to run test, I need to edit this file.
It is cumbersome.
shogo82148
Jan 31, 2021
Author
Contributor
it comes from starter workflows https://github.com/actions/starter-workflows/blob/c59b62dee0eae1f9f368b7011cf05c2fc42cf084/ci/go.yml#L3-L7
but I agree with you, and will remove it.
|
I'm a little surprised by "shogo82148/actions-setup-mysql@v1" looks great! |
|
Thank you!
me, too. |
shogo82148
merged commit 4d5208a
into
go-sql-driver:master
48 checks passed
48 checks passed
Coveralls - Windows-Go-1.15-DB-mariadb-10.3
First build on improve-github-actions at 81.394%
Details
Coveralls - Windows-Go-1.15-DB-mariadb-10.4
First build on improve-github-actions at 81.394%
Details
Coveralls - Windows-Go-1.15-DB-mariadb-10.5
First build on improve-github-actions at 81.394%
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Checklist