Skip to content

bpo-43417: Better buffer handling for ast.unparse #24772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2021
Merged

bpo-43417: Better buffer handling for ast.unparse #24772

merged 1 commit into from
May 8, 2021

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Mar 6, 2021 •
edited by bedevere-bot
Loading

isidentical
isidentical commented Mar 6, 2021
View reviewed changes
Lib/ast.py
Comment on lines -1182 to -1183
if conversion not in "sra":
raise ValueError("Unknown f-string conversion.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of handling invalid cases in the ast.unparse if they are not going to break the rest of the code, which they won't in this case.

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 6, 2021
@isidentical isidentical removed the stale Stale PR or inactive for long period of time. label May 8, 2021
@isidentical isidentical merged commit 3d98ece into python:main May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isidentical @the-knights-who-say-ni @bedevere-bot