Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42994: Add MIME types for opus, AAC, 3gpp and 3gpp2 #24287

Merged
merged 2 commits into from Mar 3, 2021

Conversation

ndbeals
Copy link
Contributor

@ndbeals ndbeals commented Jan 21, 2021

Add MIME types for opus, AAC, 3gpp and 3gpp2. Some types have multiple extensions, the IANA preferred extension comes first.

These are officially recognized MIME types by IANA: https://www.iana.org/assignments/media-types/media-types.xhtml#audio

https://bugs.python.org/issue42994

@github-actions
Copy link

@github-actions github-actions bot commented Feb 21, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Feb 21, 2021
@ndbeals
Copy link
Contributor Author

@ndbeals ndbeals commented Feb 23, 2021

I've pinged the issue on the python bug tracker as per the contributing guidelines.

@github-actions github-actions bot removed the stale label Feb 24, 2021
@ypankovych
Copy link
Contributor

@ypankovych ypankovych commented Mar 2, 2021

LGTM

FFY00
FFY00 approved these changes Mar 2, 2021
Copy link
Member

@orsenthil orsenthil left a comment

LGTM.

@orsenthil orsenthil merged commit 3a87e56 into python:master Mar 3, 2021
11 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 3, 2021

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@ndbeals
Copy link
Contributor Author

@ndbeals ndbeals commented Mar 3, 2021

Thanks for reviewing and merging this.

gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Mar 10, 2021
Co-authored-by: Nathan Beals <ndbeals@users.noreply.github.com>
kreathon pushed a commit to kreathon/cpython that referenced this issue May 2, 2021
Co-authored-by: Nathan Beals <ndbeals@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants