Skip to content

/ cube.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@cubejs-client/ws-transport): Move to TypeScript #1293

Merged
merged 6 commits into from Nov 5, 2020
Merged

feat(@cubejs-client/ws-transport): Move to TypeScript #1293

merged 6 commits into from Nov 5, 2020

Conversation

@ovr
Copy link
Member

@ovr ovr commented Nov 3, 2020 •
edited

Hello!

refs #1091

Thanks
@ovr ovr marked this pull request as draft Nov 3, 2020
@ovr ovr changed the title Websocket move to typescript feat(@cubejs-client/ws-transport): Move to TypeScript Nov 3, 2020
@ovr ovr mentioned this pull request Nov 3, 2020
Open
6 of 32 tasks complete
@ovr ovr force-pushed the websocket-move-to-typescript branch from 8e29947 to b6b68a8 Nov 5, 2020
@ovr
misc(rollup): Support TypeScript for Client libraries
Verified
This commit was signed with a verified signature.
ovr Dmitry Patsura
GPG key ID: 503DBE40373517B0 Learn about signing commits
59d6df7
@ovr ovr force-pushed the websocket-move-to-typescript branch from b6b68a8 to f364894 Nov 5, 2020
ovr added 4 commits Nov 3, 2020
@ovr
feat(@cubejs-client/ws-transport): Move to TypeScript
Verified
This commit was signed with a verified signature.
ovr Dmitry Patsura
GPG key ID: 503DBE40373517B0 Learn about signing commits
aaa7981
@ovr
feat(@cubejs-client/ws-transport): Generate d.ts file by TSC (with hack)
Verified
This commit was signed with a verified signature.
ovr Dmitry Patsura
GPG key ID: 503DBE40373517B0 Learn about signing commits
2add8ba
@ovr
misc(@cubejs-client/ws-transport): Add documentation reference
Verified
This commit was signed with a verified signature.
ovr Dmitry Patsura
GPG key ID: 503DBE40373517B0 Learn about signing commits
033d0cc
@ovr
misc(@cubejs-client/ws-transport): Generate docs
Verified
This commit was signed with a verified signature.
ovr Dmitry Patsura
GPG key ID: 503DBE40373517B0 Learn about signing commits
Loading status checks…
40bb332
@ovr ovr force-pushed the websocket-move-to-typescript branch from f364894 to 40bb332 Nov 5, 2020
@ovr ovr requested a review from vasilev-alex Nov 5, 2020
@ovr ovr marked this pull request as ready for review Nov 5, 2020
@vasilev-alex
vasilev-alex approved these changes Nov 5, 2020
View changes
@hassankhan
hassankhan reviewed Nov 5, 2020
View changes
packages/cubejs-client-ws-transport/src/index.ts Show resolved Hide resolved
@ovr ovr force-pushed the websocket-move-to-typescript branch from 39efa0d to 98b8560 Nov 5, 2020
@ovr
feat(@cubejs-client/ws-transport): Deprecate hearBeatInterval, please…
Verified
This commit was signed with a verified signature.
ovr Dmitry Patsura
GPG key ID: 503DBE40373517B0 Learn about signing commits
Loading status checks…
dfc6a62 
… use heartBeatInterval
@ovr ovr force-pushed the websocket-move-to-typescript branch from 98b8560 to dfc6a62 Nov 5, 2020
@ovr ovr merged commit e7e1100 into master Nov 5, 2020
25 checks passed
25 checks passed
unit (10.x)
Details
unit (10.x)
Details
unit (12.x)
Details
unit (12.x)
Details
unit (14.x)
Details
unit (14.x)
Details
unit (15.x)
Details
unit (15.x)
Details
lint lint
Details
lint lint
Details
build
Details
build
Details
integration-wrk-1 (12.x)
Details
integration-wrk-1 (12.x)
Details
integration-wrk-2 (12.x)
Details
integration-wrk-2 (12.x)
Details
integration-wrk-3 (12.x)
Details
integration-wrk-3 (12.x)
Details
Build only :dev image
Details
Build only :dev image
Details
docker-image-latest-set-tag
Details
docker-image-latest-set-tag
Details
Build only :latest image
Details
Build only :latest image
Details
License Compliance All checks passed.
Details
@ovr ovr deleted the websocket-move-to-typescript branch Nov 5, 2020
vasilev-alex added a commit that referenced this pull request Dec 14, 2020
@ovr @vasilev-alex
feat(@cubejs-client/ws-transport): Move to TypeScript (#1293)
1a1fe16 
* misc(rollup): Support TypeScript for Client libraries

* feat(@cubejs-client/ws-transport): Move to TypeScript

* feat(@cubejs-client/ws-transport): Generate d.ts file by TSC (with hack)

* misc(@cubejs-client/ws-transport): Add documentation reference

* misc(@cubejs-client/ws-transport): Generate docs

* feat(@cubejs-client/ws-transport): Deprecate hearBeatInterval, please use heartBeatInterval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassankhan hassankhan

@vasilev-alex vasilev-alex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ovr @hassankhan @vasilev-alex