Skip to content

Fixes issue where logs were unavailable for RemoteWebDriver #8886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixes issue where logs were unavailable for RemoteWebDriver #8886

wants to merge 2 commits into from

Conversation

jordan-mace
Copy link
Contributor

@jordan-mace jordan-mace commented Nov 19, 2020 •
edited
Loading

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Makes RemoteWebDriver implement ISupportsLogs
This has been tested with the example given in #8229

Motivation and Context

Closes issue #8229

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jimevans
Copy link
Member

I oppose this change. It propagates support for logs to all subclasses of RemoteWebDriver, even for those subclasses (like IE) where logs are expressly not supported. I do have a refactoring plan for how to resolve this, but simply adding the interface to the base RemoteWebDriver class is not the way to accomplish it.

@jordan-mace
Copy link
Contributor Author

I oppose this change. It propagates support for logs to all subclasses of RemoteWebDriver, even for those subclasses (like IE) where logs are expressly not supported. I do have a refactoring plan for how to resolve this, but simply adding the interface to the base RemoteWebDriver class is not the way to accomplish it.

I was not aware that IE explicitly does not support logs, understandable. What would your refactoring plan be?

@barancev barancev added the C-dotnet .NET Bindings label Jan 22, 2021
@jordan-mace jordan-mace deleted the issue_8229 branch March 16, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-dotnet .NET Bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordan-mace @jimevans @barancev