MAINT: Add annotations for dtype.__getitem__, __mul__ and names
#18598
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
added
09 - Backport-Candidate
|
Thanks, that was fast! |
BvB93
commented
Mar 11, 2021
Comment on lines
+753
to
+755
| # NOTE: `__rmul__` seems to be broken when used in combination with | ||
| # literals as of mypy 0.800. Set the return-type to `Any` for now. | ||
| def __rmul__(self, value: int) -> Any: ... |
There was a problem hiding this comment.
This is rather unfortunate, but it's something that we'll have to deal with.
rgommers
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xref #18597.
A couple of method-annotations were missing from
np.dtype; they have now been added:__getitem____mul__and__rmul__names