-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Added new scientific reference of MCC in the _classification.py page #18707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dear scikit-learn developers, I am proposing to include the reference to this article of mine about the Matthews correlation coefficient because it describes some mathematical properties of MCC, some mathematical relationships between MCC and other measures (F1 score and accuracy), and some use cases about how it works and what message it generates. I am available to provide additional information, of course. Thanks for considering my pull request. -- Davide |
Can someone let me know if my request can be considered? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @davidechicco !
I do not think we have an "inclusion criterion" for references. Given the number of citations this paper has, I would be +1 with adding it.
(I also found the paper easy to read, nice work!)
I've not yet read the article, but perhaps it is better situated in the
discussion of metrics in the user guide
|
Can we proceed with the pull request merge? Thank you |
Did you have a response to my suggestion? In the user guide you would specifically note the conclusion of your work. The docstring references tend to pertain to the definition or scope of a metric, not the respective advantages. |
Hi, thanks for your suggestion. I checked the user guide and found no references to scientific articles. Do you refer to this document or to something else? |
I think most of the references in A good example of references for a metric is the DET User guide. You can place references for MCC in |
Thanks for the suggestion; I will try to do it. I will close this issue then. |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
I only added the reference to my article on the Matthews correlation coefficient (MCC) webpage, thinking that it can be useful to the users.
Any other comments?