Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix element creation for large dataset #8388

Merged
merged 3 commits into from Feb 5, 2021
Merged

Fix element creation for large dataset #8388

merged 3 commits into from Feb 5, 2021
+38 −5

Conversation

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Feb 5, 2021

Closes #8387
@kurkle
Fix element creation for large dataset
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
bf71b11
@kurkle kurkle added the type: bug label Feb 5, 2021
@kurkle kurkle added this to the Version 3.0 milestone Feb 5, 2021
@etimberg
etimberg reviewed Feb 5, 2021
View changes
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Feb 5, 2021

Oops, broke some tests.
@kurkle
Fix syncing
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
a6ea3fd
@kurkle
Remove duplication
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
b4edbde
@etimberg
etimberg approved these changes Feb 5, 2021
View changes
@etimberg etimberg merged commit 505afa7 into chartjs:master Feb 5, 2021
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage decreased (-0.01%) to 95.011%
Details
Coveralls - ubuntu-latest-firefox Coverage increased (+0.003%) to 94.92%
Details
Coveralls - windows-latest-chrome Coverage decreased (-0.01%) to 95.011%
Details
Coveralls - windows-latest-firefox Coverage increased (+0.003%) to 94.92%
Details
codeclimate All good!
Details
coverage/coveralls Coverage increased (+0.003%) to 95.027%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Linked issues

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded with large amount of points
2 participants
@kurkle @etimberg