first local test run requires npm run build
#222
Projects
Comments
Closed
This issue is stale because it has been open 60 days with no activity. |
This was referenced Jan 21, 2021
This was referenced Jan 27, 2021
For the short term, we've also clarified this in the contributing/development documentation: 054f9ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A fresh clone of this repo requires
npm run build
to be run before all the tests will pass. This is an easy thing to forget because you only have to run it once and thennpm test
continues to work without a fresh build.One way we can work around this is by adding a
pretest
script to package.json with a value ofnpm run build
. That way the build will always run first when anyone runsnpm test
.That would solve the immediate problem for first-time contributors, but it would also incur a performance penalty every time you run the tests locally, as the build currently takes ~4 seconds to run on my superfast computer. Maybe 4s doesn't matter much in the grand scheme of things... but it would be nice to not incur that cost.
cc @github/docs-engineering @jeffmcaffer
The text was updated successfully, but these errors were encountered: