Skip to content

[8.x] PHPUnit 10 Support #36043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[8.x] PHPUnit 10 Support #36043

wants to merge 3 commits into from

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 25, 2021 •
edited
Loading

Pending PHPUnit v10 release.

@driesvints driesvints marked this pull request as draft January 25, 2021 19:58
@GrahamCampbell
Copy link
Member

Maybe we should do the same actions trick you did for browserkit, here @driesvints?

@realodix realodix mentioned this pull request May 2, 2021
Closed
@nuernbergerA
Copy link
Contributor

@driesvints phpunit.xml.dist will be renamed to phpunit.dist.xml

See sebastianbergmann/phpunit@07a022a

@crynobone
Copy link
Member

@nuernbergerA we can't rename it until we remove support for older PHPUnit versions.

@nuernbergerA
Copy link
Contributor

@crynobone yeah you are right maybe it's a thing for 9.x

@crynobone
Copy link
Member

9.x still needs to support PHP 7.4, which PHPUnit 10 doesn't support.

@driesvints
Copy link
Member Author

@crynobone @nuernbergerA even so: it doesn't seems to me that the old convention will be removed?

@nuernbergerA
Copy link
Contributor

@driesvints I think it will be removed in V12 so there is plenty of time

@driesvints driesvints mentioned this pull request Jun 17, 2021
Merged
@driesvints
Copy link
Member Author

Gonna close this until there's more news on PHPUnit 10's release date.

@driesvints driesvints closed this Sep 2, 2021
@driesvints driesvints deleted the phpunit10 branch September 2, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valehasadli valehasadli valehasadli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@driesvints @GrahamCampbell @nuernbergerA @crynobone @valehasadli