Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New fractals folder #4277

Merged
merged 10 commits into from Mar 20, 2021
Merged

New fractals folder #4277

merged 10 commits into from Mar 20, 2021
+0 −0

Conversation

@algobytewise
Copy link
Contributor

@algobytewise algobytewise commented Mar 20, 2021

Describe your change:

new folder for fractals

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
algobytewise added 10 commits Feb 23, 2021
@algobytewise
Merge pull request #1 from TheAlgorithms/master
ec738b0 
sync fork
@algobytewise
Merge pull request #2 from TheAlgorithms/master
5ee6c48 
update fork
@algobytewise
Merge pull request #3 from TheAlgorithms/master
1367811 
update fork
@algobytewise
reupload
681d30c
@algobytewise
Merge pull request #4 from TheAlgorithms/master
8467a83 
update fork
@algobytewise
Merge pull request #5 from TheAlgorithms/master
7dcd57b 
sync fork
@algobytewise
delete file
c80db33
@algobytewise
Move koch_snowflake.py to fractals-folder
b3c343a
@algobytewise
Move mandelbrot.py to fractals-folder
f402ee4
@algobytewise
Move sierpinski_triangle.py to fractals-folder
5af8de1
@cclauss
cclauss approved these changes Mar 20, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

I am not usually a fan of adding new root directories but I just love fractals!!

It would be cool if you could look in the others directory and find better homes for some of those algorithms. My sense is that visitors will have a hard time finding uncategorized algorithms.
@cclauss cclauss merged commit 8f5f32b into TheAlgorithms:master Mar 20, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
@algobytewise
Copy link
Contributor Author

@algobytewise algobytewise commented Mar 20, 2021

We could add the fractals-folder to the graphics-folders but that's not a perfect match.

@algobytewise
Copy link
Contributor Author

@algobytewise algobytewise commented Mar 20, 2021

I'll have a look throught the others-folder once I get the time.

@algobytewise algobytewise deleted the algobytewise:new-fractals-folder branch Mar 21, 2021
peRFectBeliever added a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@algobytewise @peRFectBeliever
New fractals folder (TheAlgorithms#4277)
fb65742 
* reupload

* delete file

* Move koch_snowflake.py to fractals-folder

* Move mandelbrot.py to fractals-folder

* Move sierpinski_triangle.py to fractals-folder
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@algobytewise
New fractals folder (TheAlgorithms#4277)
68642c3 
* reupload

* delete file

* Move koch_snowflake.py to fractals-folder

* Move mandelbrot.py to fractals-folder

* Move sierpinski_triangle.py to fractals-folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@algobytewise @cclauss