upgrade to node 14 #41544

josephperrott · 2021-04-09T22:30:32Z

Upgrades the repository to use node 14. Additionally, removes support for node 10 as it has
reached end of life.

BREAKING CHANGE: Angular no longer maintains support for node v10

Note: Only core scope commit includes a breaking change note to prevent the same note from occurring many times.

The text was updated successfully, but these errors were encountered:

alan-agius4 · 2021-04-10T06:36:20Z

packages/platform-server/package.json

@@ -34,9 +34,6 @@
    "./__ivy_ngcc__/esm2015/init/src/init.js",
    "./__ivy_ngcc__/fesm2015/init.js"
  ],
-  "engines": {


Why the “engines” field was removed from here (and other packages)

This is useful if users are installing this package in an older node.js environment, which will cause a warning or a error based on the package manager and its settings.

Should we just set the engines field in @angular/core's package.json since it essentially is always needed to use any of the packages? Alternatively we could set it for all packages we release.

@jelbourn thoughts on the above?

Seems like the "technically correct" thing is to list it on each package, no? I would probably do that unless there's some reason not too (like if it were to generate extra console noise).

The change seems to have the engines set on everything now, though, yes?

Yes, this change makes the engines value appear in everyone packages package.json. If someone were to be using an unsupported version of node, they would see a warning during node install for each package they rely on.

alan-agius4

Shouldn’t the changes be split into 2 commits?

ci: update to use Node 14
feat(core): drop support for Node 10

gkalpak

Yesss 🎊 🎉 🎇
Please also update .devcontainer/recommended-Dockerfile.

FWIW, I believe the changes should be split up into two commits: one that updates the version of Node.js used in the repo and another one that updates the engines in the various packages (compiler-cli, localize, platform-server).

.circleci/config.yml

.nvmrc

packages/core/package.json

devversion

LGTM. I assume we can't use 14.16.1 for Bazel yet as we aren't on the latest rules_nodejs version, right?

NodeJS v14 is the current LTS version and we should switch as the Angular framework/dev-infra also updates to Node V14. See angular/angular#41544 We remove the engines filed in non-top-level `package.json` files to avoid unnecessary churn. We keep NodeJS v12 working as this is the minimum required version for framework too and diverging could cause productivity issues when switching between projects.

gkalpak

LGTM ✔️

alfaproject · 2021-04-14T16:00:33Z

I don't quite understand why you are publishing a library that is mostly used in a browser context with the engines field. I could understand platform-server, or compiler-cli or angular-cli in general, but why the rest?

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. BREAKING CHANGE: Angular no longer maintains support for node v10 PR Close #41544

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

…ns (#41544) Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

petebacondarwin · 2021-04-14T16:42:37Z

I don't quite understand why you are publishing a library that is mostly used in a browser context with the engines field. I could understand platform-server, or compiler-cli or angular-cli in general, but why the rest?

Indeed we were just discussing this. There is the slight oddity that even things like core might end up being executed inside node.js if you are doing SSR. As a team we are on the fence and slightly falling on the side of just adding the engine field to all our packages for consistency.

NodeJS v14 is the current LTS version and we should switch as the Angular framework/dev-infra also updates to Node V14. See angular/angular#41544 We remove the engines filed in non-top-level `package.json` files to avoid unnecessary churn. We keep NodeJS v12 working as this is the minimum required version for framework too and diverging could cause productivity issues when switching between projects.

JounQin · 2021-05-13T03:26:42Z

May I ask why Node v16 is not supported? Is there any known issue?

josephperrott · 2021-05-13T15:55:31Z

@JounQin There are not any known issues, and I would even guess that it will work perfectly well. However, Node v16 is in the Current release status per https://nodejs.org/en/about/releases/. Angular only supports versions of Node which are in Active LTS or Maintenance LTS.

We should begin supporting v16 ~End of October 2021 as this is when it will begin Active LTS.

marlass · 2021-05-13T18:14:37Z

~~@josephperrott In this case it might be worth updating that info in the docs: https://angular.io/guide/setup-local#prerequisites where current is mentioned in the support list.~~

Nevermind. I see it's updated there

NodeJS v14 is the current LTS version and we should switch as the Angular framework/dev-infra also updates to Node V14. See angular/angular#41544 We remove the engines filed in non-top-level `package.json` files to avoid unnecessary churn. We keep NodeJS v12 working as this is the minimum required version for framework too and diverging could cause productivity issues when switching between projects.

angular-automatic-lock-bot · 2021-06-13T16:06:22Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

josephperrott added comp: build & ci action: review target: major labels Apr 9, 2021

josephperrott requested review from mgechev and devversion Apr 9, 2021

ngbot bot added this to the Backlog milestone Apr 9, 2021

google-cla bot added the cla: yes label Apr 9, 2021

josephperrott added the breaking changes label Apr 9, 2021

josephperrott marked this pull request as ready for review Apr 9, 2021

pullapprove bot requested review from alxhub and petebacondarwin Apr 9, 2021

alan-agius4 reviewed Apr 10, 2021

View changes

gkalpak requested changes Apr 10, 2021

View changes

.circleci/config.yml Outdated Show resolved Hide resolved

petebacondarwin added the action: cleanup label Apr 12, 2021

pullapprove bot requested review from AndrewKushnir, atscott and jelbourn Apr 12, 2021

devversion reviewed Apr 12, 2021

View changes

.nvmrc Outdated Show resolved Hide resolved

AndrewKushnir reviewed Apr 12, 2021

View changes

packages/core/package.json Outdated Show resolved Hide resolved

josephperrott force-pushed the upgrade-node branch from 1b60148 to 5376141 Apr 12, 2021

josephperrott requested a review from gkalpak Apr 12, 2021

AndrewKushnir approved these changes Apr 12, 2021

View changes

devversion approved these changes Apr 12, 2021

View changes

josephperrott removed the action: cleanup label Apr 12, 2021

josephperrott changed the title ~~feat(core): upgrade to node 14~~ upgrade to node 14 Apr 13, 2021

devversion mentioned this pull request Apr 13, 2021

build: update rules_nodejs and update to NodeJS v14 angular/components#22472

Merged

josephperrott force-pushed the upgrade-node branch from 3534e0a to 7b36ece Apr 14, 2021

gkalpak approved these changes Apr 14, 2021

View changes

zarend closed this in ee615e0 Apr 14, 2021

zarend added a commit that referenced this issue Apr 14, 2021

feat(animations): update supported range of node versions (#41544)

547363a

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(bazel): update supported range of node versions (#41544)

d583d92

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(common): update supported range of node versions (#41544)

e0250e5

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(compiler-cli): update supported range of node versions (#41544)

b7bd238

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(compiler): update supported range of node versions (#41544)

75cc813

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(elements): update supported range of node versions (#41544)

12fc08b

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(forms): update supported range of node versions (#41544)

a0006a6

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(localize): update supported range of node versions (#41544)

590d4dd

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(platform-server): update supported range of node versions (#41544)

c901b4d

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(router): update supported range of node versions (#41544)

c30b171

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(service-worker): update supported range of node versions (#41544)

fc597f1

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

zarend added a commit that referenced this issue Apr 14, 2021

feat(upgrade): update supported range of node versions (#41544)

beafa22

Update the supported range of node versions for Angular. Angular now supports node >=12.14.1 to <16.0.0, dropping support for Node v10. PR Close #41544

josephperrott deleted the upgrade-node branch May 13, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2021

angular / angular Public

upgrade to node 14 #41544

upgrade to node 14 #41544

josephperrott commented Apr 9, 2021 •

edited

alan-agius4 Apr 10, 2021 •

edited

josephperrott Apr 12, 2021

josephperrott Apr 12, 2021

jelbourn Apr 13, 2021

josephperrott Apr 13, 2021

alan-agius4 left a comment •

edited

gkalpak left a comment

devversion left a comment

gkalpak left a comment

alfaproject commented Apr 14, 2021

petebacondarwin commented Apr 14, 2021

JounQin commented May 13, 2021

josephperrott commented May 13, 2021

marlass commented May 13, 2021 •

edited

angular-automatic-lock-bot bot commented Jun 13, 2021

angular / angular Public

upgrade to node 14 #41544

upgrade to node 14 #41544

Conversation

josephperrott commented Apr 9, 2021 • edited

alan-agius4 Apr 10, 2021 • edited

josephperrott Apr 12, 2021

josephperrott Apr 12, 2021

jelbourn Apr 13, 2021

josephperrott Apr 13, 2021

alan-agius4 left a comment • edited

gkalpak left a comment

devversion left a comment

gkalpak left a comment

alfaproject commented Apr 14, 2021

petebacondarwin commented Apr 14, 2021

JounQin commented May 13, 2021

josephperrott commented May 13, 2021

marlass commented May 13, 2021 • edited

angular-automatic-lock-bot bot commented Jun 13, 2021

josephperrott commented Apr 9, 2021 •

edited

alan-agius4 Apr 10, 2021 •

edited

alan-agius4 left a comment •

edited

marlass commented May 13, 2021 •

edited