Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flag #25520

Merged
merged 10 commits into from Apr 28, 2021
Merged

bpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flag #25520

merged 10 commits into from Apr 28, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 22, 2021 •
edited by bedevere-bot

@erlend-aasland erlend-aasland marked this pull request as ready for review Apr 22, 2021
gvanrossum
gvanrossum reviewed Apr 24, 2021
View changes
Doc/c-api/typeobj.rst Outdated Show resolved Hide resolved
shreyanavigyan
shreyanavigyan reviewed Apr 26, 2021
View changes
Doc/c-api/typeobj.rst Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland marked this pull request as draft Apr 26, 2021
@erlend-aasland erlend-aasland changed the title bpo-43908: Add Py_TPFLAGS_IMMUTABLE flag and use it in arraymodule bpo-43908: Add Py_TPFLAGS_IMMUTABLE flag Apr 26, 2021
@erlend-aasland erlend-aasland marked this pull request as ready for review Apr 26, 2021
@erlend-aasland erlend-aasland requested a review from gvanrossum Apr 26, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 26, 2021

cc. @pablogsal @vstinner @serhiy-storchaka @tiran

@erlend-aasland erlend-aasland changed the title bpo-43908: Add Py_TPFLAGS_IMMUTABLE flag bpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flag Apr 26, 2021
pablogsal
pablogsal reviewed Apr 26, 2021
View changes
Objects/typeobject.c Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 27, 2021

@pablogsal are you ok with the PR as it is?

vstinner
vstinner reviewed Apr 28, 2021
View changes
Doc/c-api/typeobj.rst Outdated Show resolved Hide resolved
Doc/c-api/typeobj.rst Outdated Show resolved Hide resolved
Include/object.h Outdated Show resolved Hide resolved
Objects/typeobject.c Show resolved Hide resolved
Erlend Egeberg Aasland and others added 3 commits Apr 28, 2021
@vstinner
Improve docs
025af5b 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Improve docs
0e8c709 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Improve comment
8c79eae 
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend Egeberg Aasland and others added 3 commits Apr 28, 2021
vstinner
vstinner reviewed Apr 28, 2021
View changes
Doc/c-api/typeobj.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/C API/2021-04-22-10-46-40.bpo-43908.Co3YhZ.rst Outdated Show resolved Hide resolved
Objects/typeobject.c Show resolved Hide resolved
Erlend Egeberg Aasland and others added 2 commits Apr 28, 2021
@vstinner
Spelling fix
3032d3b 
Co-authored-by: Victor Stinner <vstinner@python.org>
Improve NEWS wording
edf4097
vstinner
vstinner approved these changes Apr 28, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

IMO it was important to mention "type attributes cannot be set nor deleted" to explain what "immutable" means. I stop nitpicking, let's move on to add this flag to types recently converted to heap types.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 28, 2021

Thanks, @vstinner! I appreciate the doc/comment nitpicking; you're improved the PR considerably.

@vstinner
Copy link
Member

vstinner commented Apr 28, 2021

@erlend-aasland: Travis CI failed:

Fixing docs whitespace ... 1 file:

  Doc/c-api/typeobj.rst

Please fix the 1 file(s) with whitespace issues

(on UNIX you can run `make patchcheck` to make the fixes)

shreyanavigyan
shreyanavigyan reviewed Apr 28, 2021
View changes
Doc/c-api/typeobj.rst Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 28, 2021

@erlend-aasland: Travis CI failed:

Oops, I'll fix it. I normally do make html in the Doc directory to make sure I've got the reST markup right.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 28, 2021

FYI, unrelated random ssl test failure on the macOS CI, @vstinner.

@vstinner vstinner merged commit 3b52c8d into python:master Apr 28, 2021
11 of 12 checks passed
@vstinner
Copy link
Member

vstinner commented Apr 28, 2021

Merged, thanks.

@erlend-aasland erlend-aasland deleted the immutable-types branch Apr 28, 2021
@pablogsal
Copy link
Member

pablogsal commented Apr 28, 2021 •
edited

FYI, unrelated random ssl test failure on the macOS CI, @vstinner.

CC: @tiran This is happening white a lot

kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@vstinner @kreathon
bpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flag (pythonGH-25520)
4d9a651 
Introduce Py_TPFLAGS_IMMUTABLETYPE flag for immutable type objects, and
modify PyType_Ready() to set it for static types.

Co-authored-by: Victor Stinner <vstinner@python.org>
@gvanrossum gvanrossum mentioned this pull request May 18, 2022
Closed
@maxbachmann maxbachmann mentioned this pull request Sep 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@shreyanavigyan shreyanavigyan

@vstinner vstinner

@markshannon markshannon

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@erlend-aasland @vstinner @pablogsal @gvanrossum @shreyanavigyan @the-knights-who-say-ni @bedevere-bot