Matplotlylib fixes #3143
Open
Matplotlylib fixes #3143
+144
−29
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
This PR fixes compatibility of matplotlylib with matplotib
3.3
and above and specifically tested with the latest release (3.4.1
). Before fixing the compatibility, I fixed any matplotlylib tests that were not passing. Then I fixed the code.Specifically, this addresses changes to
matplotlib
:It also renders the shapes for the matplotib legend (previously, only the text would display in a legend). This is mainly done through the method
draw_legend_shapes
which is called bydraw_marked_line
and handles lines, markers and lines+markers. It doesn't handle the legend bounding box.Tested with matplotlib 3.2,2 (last known working with matplotlylib, with warnings) and 3.4.1 (current), from notebooks with various charts / markers. Also tested with

hotelling
package with `matplotlib 3.4.1.