Require python 3.6 and CI maintenance #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ese from core requirements
The requirements.txt for these versions uses up-to-date dependency versions
…xt as the other tests
8 tasks
|
Yeah, that makes sense. I'll go ahead and merge #2911 and update this PR. |
# Conflicts: # .circleci/config.yml # packages/python/plotly/tox.ini
jonmmease
changed the title
|
ping @nicolaskruchten, I think this is ready to go now. I added a few notes above for some follow ups that we can do next. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR removes support for Python versions prior to 3.6 and does some clean up of the CI test suite. In particular, it removes the use of tox and instead relies on a separate requirements.txt file for each Python version. This makes it possible to test different versions of dependencies.
Still to do in follow-on PR(s)
Addresses parts of #3159 and closes #3158