Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imshow now handles DataFrame indexes and names by default #2539

Merged
merged 5 commits into from Jul 8, 2020
Merged

imshow now handles DataFrame indexes and names by default #2539

merged 5 commits into from Jul 8, 2020

Conversation

nicolaskruchten
Copy link
Member

@nicolaskruchten nicolaskruchten commented Jun 5, 2020 •
edited

  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@nicolaskruchten nicolaskruchten requested a review from emmanuelle Jun 5, 2020
@nicolaskruchten
Copy link
Member Author

@nicolaskruchten nicolaskruchten commented Jun 5, 2020

Meh, this is "new functionality" and so should go into a minor not a patch.

@nicolaskruchten nicolaskruchten added this to the 4.9.0 milestone Jun 5, 2020
emmanuelle
emmanuelle reviewed Jun 12, 2020
View changes
CHANGELOG.md Outdated Show resolved Hide resolved
@emmanuelle
Copy link
Contributor

@emmanuelle emmanuelle commented Jun 12, 2020

Thanks, 💃

nicolaskruchten and others added 2 commits Jun 12, 2020
@nicolaskruchten @emmanuelle
Update CHANGELOG.md
85041ae 
Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
@nicolaskruchten
Merge branch 'master' into imshow_df
7f1616b
@nicolaskruchten nicolaskruchten merged commit c7282c7 into master Jul 8, 2020
0 of 16 checks passed
@nicolaskruchten nicolaskruchten deleted the imshow_df branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.0
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolaskruchten @emmanuelle