Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept integer and float columns in wide mode #2598

Merged
merged 3 commits into from Jun 25, 2020
Merged

accept integer and float columns in wide mode #2598

merged 3 commits into from Jun 25, 2020

Conversation

nicolaskruchten
Copy link
Member

@nicolaskruchten nicolaskruchten commented Jun 25, 2020 •
edited

Closes #2561

Code PR

  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@nicolaskruchten nicolaskruchten requested a review from emmanuelle Jun 25, 2020
@nicolaskruchten nicolaskruchten added this to the 4.8.2 milestone Jun 25, 2020
@emmanuelle
Copy link
Contributor

@emmanuelle emmanuelle commented Jun 25, 2020

💃 (I suggested to add "u" in the number types)

@nicolaskruchten @emmanuelle
Update packages/python/plotly/plotly/express/_core.py
c9742e0 
Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
@nicolaskruchten
Copy link
Member Author

@nicolaskruchten nicolaskruchten commented Jun 25, 2020

Awesome, thanks for catching that... I'm not as familiar with the types here as I should be :)

@nicolaskruchten nicolaskruchten merged commit 5f87ec4 into master Jun 25, 2020
17 checks passed
@nicolaskruchten nicolaskruchten deleted the loosen_wide_typecheck branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.2
Linked issues

Successfully merging this pull request may close these issues.

wide-mode type checking too strict
2 participants
@nicolaskruchten @emmanuelle